Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting the name of the variable #2162

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

cniackz
Copy link
Contributor

@cniackz cniackz commented Jun 12, 2024

Objective:

  • First of all, thank you @pjuarezd for this documentation, it worked!
  • Minor correction: the variable CONSOLE_IDP_CALBACK is missing an L and should be CONSOLE_IDP_CALLBACK.

User Story:

When I copied the variable name from the documentation, I got stuck for hours with this error:

Unable to issue redirect for OAuth 2.0 transaction

I even created a Stack Overflow question before I figured it out:

https://stackoverflow.com/questions/78614194/unable-to-issue-redirect-for-oauth-2-0-transaction-when-using-go-project

That said, the correction is very simple and can help other users avoid the problem I had today. 👍

@cniackz cniackz requested review from pjuarezd and ravindk89 June 12, 2024 17:39
@cniackz cniackz self-assigned this Jun 12, 2024
@cniackz cniackz requested review from dvaldivia and feorlen June 12, 2024 17:43
@cniackz cniackz added the IdP label Jun 12, 2024
Copy link
Contributor

@feorlen feorlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I'll also check if there's anything to correct in the web docs for this

@pjuarezd pjuarezd merged commit 54e4091 into minio:master Jun 12, 2024
31 checks passed
@cniackz cniackz deleted the correct-env-var branch June 12, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants